Add support for http status code as a field #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
nc-post-code
branch
from
81589b6
to
37c8ea1
Compare
desa
reviewed
Sep 21, 2017
| } else { | ||
| err = errors.New("unknown error, use .captureResponse() to capture the HTTP response") | ||
| } | ||
| n.diag.Error("POST returned non 2xx status code", err, keyvalue.KV("code", strconv.Itoa(resp.StatusCode))) |
There was a problem hiding this comment.
I just now understood what you were saying here #1535 (comment) about making everything strings.
desa
suggested changes
Sep 21, 2017
services/httppost/service.go
Outdated
| } else { | ||
| err = errors.New("unknown error, use .captureResponse() to capture the HTTP response") | ||
| } | ||
| h.diag.WithContext(keyvalue.KV("code", strconv.Itoa(resp.StatusCode))).Error("POST returned non 2xx status code", err) |
There was a problem hiding this comment.
WithContext returns a new diagnostic. Might be worth it to change the Error method on Diagnostic to
Error(msg string, err error, ctx ...keyvalue.T)
nathanielc
force-pushed
the
nc-post-code
branch
from
efaff80
to
932d11f
Compare
desa
approved these changes
Sep 21, 2017
nathanielc
added a commit
that referenced
this pull request
Sep 21, 2017
Add support for http status code as a field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1569